Commit c2493384 authored by Kees Cook's avatar Kees Cook Committed by Shuah Khan
Browse files

kunit: executor: Remove const from kunit_filter_suites() allocation type 

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct kunit_suite **" but the returned type will
be "struct kunit_suite * const *". Since it isn't generally possible
to remove the const qualifier, adjust the allocation type to match
the assignment.

Link: https://lore.kernel.org/r/20250426062433.work.124-kees@kernel.org


Signed-off-by: default avatarKees Cook <kees@kernel.org>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 1d31d536

lib/kunit/executor.c

+1 −1
Original line number Diff line number Diff line
@@ -177,7 +177,7 @@ kunit_filter_suites(const struct kunit_suite_set *suite_set, 


	const size_t max = suite_set->end - suite_set->start;



	copy = kcalloc(max, sizeof(*filtered.start), GFP_KERNEL);

	copy = kcalloc(max, sizeof(*copy), GFP_KERNEL);

	if (!copy) { /* won't be able to run anything, return an empty set */

		return filtered;

	}