Commit c25892b7 authored Jun 11, 2025 by Nuno Sá Committed by Guenter Roeck Jun 16, 2025

hwmon: (ltc4282) avoid repeated register write



The fault enabled bits were being mistankenly enabled twice in case the FW
property is present. Remove one of the writes.

Fixes: cbc29538 ("hwmon: Add driver for LTC4282")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20250611-fix-ltc4282-repetead-write-v1-1-fe46edd08cf1@analog.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 2c021b45

drivers/hwmon/ltc4282.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -1511,13 +1511,6 @@ static int ltc4282_setup(struct ltc4282_state st, struct device dev)
		return ret;
		}

		if (device_property_read_bool(dev, "adi,fault-log-enable")) {
		ret = regmap_set_bits(st->map, LTC4282_ADC_CTRL,
		LTC4282_FAULT_LOG_EN_MASK);
		if (ret)
		return ret;
		}

		if (device_property_read_bool(dev, "adi,fault-log-enable")) {
		ret = regmap_set_bits(st->map, LTC4282_ADC_CTRL, LTC4282_FAULT_LOG_EN_MASK);
		if (ret)