Commit c2623573 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (ina238) Correctly clamp power limits 



ina238_write_power() was attempting to clamp the user input but was
throwing away the result. Ensure that we clamp the value to the
appropriate range before it is converted into a register value.

Fixes: 0d9f596b ("hwmon: (ina238) Modify the calculation formula to adapt to different chips")
Cc: Wenliang Yan <wenliang202407@163.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent bd7e7bc2

drivers/hwmon/ina238.c

+3 −2
Original line number Diff line number Diff line
@@ -517,9 +517,10 @@ static int ina238_write_power(struct device *dev, u32 attr, long val) 
	 * Unsigned postive values. Compared against the 24-bit power register,

	 * lower 8-bits are truncated. Same conversion to/from uW as POWER

	 * register.

	 * The first clamp_val() is to establish a baseline to avoid overflows.

	 */

	regval = clamp_val(val, 0, LONG_MAX);

	regval = div_u64(val * 4 * 100 * data->rshunt, data->config->power_calculate_factor *

	regval = clamp_val(val, 0, LONG_MAX / 2);

	regval = div_u64(regval * 4 * 100 * data->rshunt, data->config->power_calculate_factor *

			1000ULL * INA238_FIXED_SHUNT * data->gain);

	regval = clamp_val(regval >> 8, 0, U16_MAX);