Commit c27c66af authored by Linus Torvalds's avatar Linus Torvalds
Browse files

fs/pipe: Fix pipe_occupancy() with 16-bit indexes 

The pipe_occupancy() logic implicitly relied on the natural unsigned
modulo arithmetic in C, but that doesn't work for the new 'pipe_index_t'
case, since any arithmetic will be done in 'int' (and here we had also
made it 'unsigned int' due to the function call boundary).

So make the modulo arithmetic explicit by casting the result to the
proper type.

Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Swapnil Sapkal <swapnil.sapkal@amd.com>
Cc: Alexey Gladkov <legion@kernel.org>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Link: https://lore.kernel.org/all/CAHk-=wjyHsGLx=rxg6PKYBNkPYAejgo7=CbyL3=HGLZLsAaJFQ@mail.gmail.com/


Fixes: 3d252160 ("fs/pipe: Read pipe->{head,tail} atomically outside pipe->mutex")
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bb2281fb

include/linux/pipe_fs_i.h

+1 −1
Original line number Diff line number Diff line
@@ -192,7 +192,7 @@ static inline bool pipe_empty(unsigned int head, unsigned int tail) 
 */

static inline unsigned int pipe_occupancy(unsigned int head, unsigned int tail)

{

	return head - tail;

	return (pipe_index_t)(head - tail);

}



/**