Commit c2a503f3 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Fix bch2_bucket_gens_init() 



Comparing the wrong bpos - this was missed because normally
bucket_gens_init() runs on brand new filesystems, but this bug caused it
to overwrite bucket_gens keys with 0s when upgrading ancient
filesystems.

Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent e150a7e8

fs/bcachefs/alloc_background.c

+1 −1
Original line number Diff line number Diff line
@@ -556,7 +556,7 @@ int bch2_bucket_gens_init(struct bch_fs *c) 
		struct bpos pos = alloc_gens_pos(iter.pos, &offset);

		int ret2 = 0;



		if (have_bucket_gens_key && bkey_cmp(iter.pos, pos)) {

		if (have_bucket_gens_key && !bkey_eq(g.k.p, pos)) {

			ret2 =  bch2_btree_insert_trans(trans, BTREE_ID_bucket_gens, &g.k_i, 0) ?:

				bch2_trans_commit(trans, NULL, NULL, BCH_TRANS_COMMIT_no_enospc);

			if (ret2)