Commit c2bd08ba authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Namhyung Kim
Browse files

treewide: remove meaningless assignments in Makefiles 

In Makefiles, $(error ), $(warning ), and $(info ) expand to the empty
string, as explained in the GNU Make manual [1]:
 "The result of the expansion of this function is the empty string."

Therefore, they are no-op except for logging purposes.

$(shell ...) expands to the output of the command. It expands to the
empty string when the command does not print anything to stdout.
Hence, $(shell mkdir ...) is no-op except for creating the directory.

Remove meaningless assignments.

[1]: https://www.gnu.org/software/make/manual/make.html#Make-Control-Functions



Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20240221134201.2656908-1-masahiroy@kernel.org


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-perf-users@vger.kernel.org
parent 25412c03

tools/perf/Makefile.config

+45 −45
Original line number Diff line number Diff line
@@ -193,11 +193,11 @@ endif 
include $(srctree)/tools/scripts/utilities.mak



ifeq ($(call get-executable,$(FLEX)),)

  dummy := $(error Error: $(FLEX) is missing on this system, please install it)

  $(error Error: $(FLEX) is missing on this system, please install it)

endif



ifeq ($(call get-executable,$(BISON)),)

  dummy := $(error Error: $(BISON) is missing on this system, please install it)

  $(error Error: $(BISON) is missing on this system, please install it)

endif



ifneq ($(NO_LIBTRACEEVENT),1)
@@ -428,46 +428,46 @@ else 
      LIBC_SUPPORT := 1

    endif

    ifeq ($(LIBC_SUPPORT),1)

      msg := $(error ERROR: No libelf found. Disables 'probe' tool, jvmti and BPF support. Please install libelf-dev, libelf-devel, elfutils-libelf-devel or build with NO_LIBELF=1.)

      $(error ERROR: No libelf found. Disables 'probe' tool, jvmti and BPF support. Please install libelf-dev, libelf-devel, elfutils-libelf-devel or build with NO_LIBELF=1.)

    else

      ifneq ($(filter s% -fsanitize=address%,$(EXTRA_CFLAGS),),)

        ifneq ($(shell ldconfig -p | grep libasan >/dev/null 2>&1; echo $$?), 0)

          msg := $(error No libasan found, please install libasan);

          $(error No libasan found, please install libasan)

        endif

      endif



      ifneq ($(filter s% -fsanitize=undefined%,$(EXTRA_CFLAGS),),)

        ifneq ($(shell ldconfig -p | grep libubsan >/dev/null 2>&1; echo $$?), 0)

          msg := $(error No libubsan found, please install libubsan);

          $(error No libubsan found, please install libubsan)

        endif

      endif



      ifneq ($(filter s% -static%,$(LDFLAGS),),)

        msg := $(error No static glibc found, please install glibc-static);

        $(error No static glibc found, please install glibc-static)

      else

        msg := $(error No gnu/libc-version.h found, please install glibc-dev[el]);

        $(error No gnu/libc-version.h found, please install glibc-dev[el])

      endif

    endif

  else

    ifndef NO_LIBDW_DWARF_UNWIND

      ifneq ($(feature-libdw-dwarf-unwind),1)

        NO_LIBDW_DWARF_UNWIND := 1

        msg := $(warning No libdw DWARF unwind found, Please install elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR);

        $(warning No libdw DWARF unwind found, Please install elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR)

      endif

    endif

    ifneq ($(feature-dwarf), 1)

      ifndef NO_DWARF

        msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);

        $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev)

        NO_DWARF := 1

      endif

    else

      ifneq ($(feature-dwarf_getlocations), 1)

        msg := $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157);

        $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157)

      else

        CFLAGS += -DHAVE_DWARF_GETLOCATIONS_SUPPORT

      endif # dwarf_getlocations

      ifneq ($(feature-dwarf_getcfi), 1)

        msg := $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.142);

        $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.142)

      else

        CFLAGS += -DHAVE_DWARF_CFI_SUPPORT

      endif # dwarf_getcfi
@@ -515,7 +515,7 @@ ifdef CORESIGHT 
      endif

    endif

  else

    dummy := $(error Error: No libopencsd library found or the version is not up-to-date. Please install recent libopencsd to build with CORESIGHT=1)

    $(error Error: No libopencsd library found or the version is not up-to-date. Please install recent libopencsd to build with CORESIGHT=1)

  endif

endif
@@ -541,7 +541,7 @@ ifndef NO_LIBELF 
  ifeq ($(feature-libelf-gelf_getnote), 1)

    CFLAGS += -DHAVE_GELF_GETNOTE_SUPPORT

  else

    msg := $(warning gelf_getnote() not found on libelf, SDT support disabled);

    $(warning gelf_getnote() not found on libelf, SDT support disabled)

  endif



  ifeq ($(feature-libelf-getshdrstrndx), 1)
@@ -558,7 +558,7 @@ ifndef NO_LIBELF 


  ifndef NO_DWARF

    ifeq ($(origin PERF_HAVE_DWARF_REGS), undefined)

      msg := $(warning DWARF register mappings have not been defined for architecture $(SRCARCH), DWARF support disabled);

      $(warning DWARF register mappings have not been defined for architecture $(SRCARCH), DWARF support disabled)

      NO_DWARF := 1

    else

      CFLAGS += -DHAVE_DWARF_SUPPORT $(LIBDW_CFLAGS)
@@ -580,11 +580,11 @@ ifndef NO_LIBELF 
          $(call detected,CONFIG_LIBBPF)

          $(call detected,CONFIG_LIBBPF_DYNAMIC)

        else

          dummy := $(error Error: No libbpf devel library found or older than v1.0, please install/update libbpf-devel);

          $(error Error: No libbpf devel library found or older than v1.0, please install/update libbpf-devel)

        endif

      else

        ifeq ($(NO_ZLIB), 1)

          dummy := $(warning Warning: Statically building libbpf not possible as zlib is missing)

          $(warning Warning: Statically building libbpf not possible as zlib is missing)

          NO_LIBBPF := 1

        else

          # Libbpf will be built as a static library from tools/lib/bpf.
@@ -599,7 +599,7 @@ endif # NO_LIBELF 


ifndef NO_SDT

  ifneq ($(feature-sdt), 1)

    msg := $(warning No sys/sdt.h found, no SDT events are defined, please install systemtap-sdt-devel or systemtap-sdt-dev);

    $(warning No sys/sdt.h found, no SDT events are defined, please install systemtap-sdt-devel or systemtap-sdt-dev)

    NO_SDT := 1;

  else

    CFLAGS += -DHAVE_SDT_EVENT
@@ -641,13 +641,13 @@ ifndef NO_LIBUNWIND 
    have_libunwind = 1

    $(call feature_check,libunwind-debug-frame-aarch64)

    ifneq ($(feature-libunwind-debug-frame-aarch64), 1)

      msg := $(warning No debug_frame support found in libunwind-aarch64);

      $(warning No debug_frame support found in libunwind-aarch64)

      CFLAGS += -DNO_LIBUNWIND_DEBUG_FRAME_AARCH64

    endif

  endif



  ifneq ($(feature-libunwind), 1)

    msg := $(warning No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR);

    $(warning No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR)

    NO_LOCAL_LIBUNWIND := 1

  else

    have_libunwind := 1
@@ -663,7 +663,7 @@ endif 


ifndef NO_LIBBPF

  ifneq ($(feature-bpf), 1)

    msg := $(warning BPF API too old. Please install recent kernel headers. BPF support in 'perf record' is disabled.)

    $(warning BPF API too old. Please install recent kernel headers. BPF support in 'perf record' is disabled.)

    NO_LIBBPF := 1

  endif

endif
@@ -676,28 +676,28 @@ endif 


ifeq ($(BUILD_BPF_SKEL),1)

  ifeq ($(filter -DHAVE_LIBELF_SUPPORT, $(CFLAGS)),)

    dummy := $(warning Warning: Disabled BPF skeletons as libelf is required by bpftool)

    $(warning Warning: Disabled BPF skeletons as libelf is required by bpftool)

    BUILD_BPF_SKEL := 0

  else ifeq ($(filter -DHAVE_ZLIB_SUPPORT, $(CFLAGS)),)

    dummy := $(warning Warning: Disabled BPF skeletons as zlib is required by bpftool)

    $(warning Warning: Disabled BPF skeletons as zlib is required by bpftool)

    BUILD_BPF_SKEL := 0

  else ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),)

    dummy := $(warning Warning: Disabled BPF skeletons as libbpf is required)

    $(warning Warning: Disabled BPF skeletons as libbpf is required)

    BUILD_BPF_SKEL := 0

  else ifeq ($(call get-executable,$(CLANG)),)

    dummy := $(warning Warning: Disabled BPF skeletons as clang ($(CLANG)) is missing)

    $(warning Warning: Disabled BPF skeletons as clang ($(CLANG)) is missing)

    BUILD_BPF_SKEL := 0

  else

    CLANG_VERSION := $(shell $(CLANG) --version | head -1 | sed 's/.*clang version \([[:digit:]]\+.[[:digit:]]\+.[[:digit:]]\+\).*/\1/g')

    ifeq ($(call version-lt3,$(CLANG_VERSION),12.0.1),1)

      dummy := $(warning Warning: Disabled BPF skeletons as reliable BTF generation needs at least $(CLANG) version 12.0.1)

      $(warning Warning: Disabled BPF skeletons as reliable BTF generation needs at least $(CLANG) version 12.0.1)

      BUILD_BPF_SKEL := 0

    endif

  endif

  ifeq ($(BUILD_BPF_SKEL),1)

    $(call feature_check,clang-bpf-co-re)

    ifeq ($(feature-clang-bpf-co-re), 0)

      dummy := $(warning Warning: Disabled BPF skeletons as clang is too old)

      $(warning Warning: Disabled BPF skeletons as clang is too old)

      BUILD_BPF_SKEL := 0

    endif

  endif
@@ -717,7 +717,7 @@ dwarf-post-unwind-text := BUG 
# setup DWARF post unwinder

ifdef NO_LIBUNWIND

  ifdef NO_LIBDW_DWARF_UNWIND

    msg := $(warning Disabling post unwind, no support found.);

    $(warning Disabling post unwind, no support found.)

    dwarf-post-unwind := 0

  else

    dwarf-post-unwind-text := libdw
@@ -743,7 +743,7 @@ ifndef NO_LOCAL_LIBUNWIND 
  ifeq ($(SRCARCH),$(filter $(SRCARCH),arm arm64))

    $(call feature_check,libunwind-debug-frame)

    ifneq ($(feature-libunwind-debug-frame), 1)

      msg := $(warning No debug_frame support found in libunwind);

      $(warning No debug_frame support found in libunwind)

      CFLAGS += -DNO_LIBUNWIND_DEBUG_FRAME

    endif

  else
@@ -772,7 +772,7 @@ ifneq ($(NO_LIBTRACEEVENT),1) 
    ifndef NO_LIBAUDIT

      $(call feature_check,libaudit)

      ifneq ($(feature-libaudit), 1)

        msg := $(warning No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev);

        $(warning No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev)

        NO_LIBAUDIT := 1

      else

        CFLAGS += -DHAVE_LIBAUDIT_SUPPORT
@@ -785,7 +785,7 @@ endif 


ifndef NO_LIBCRYPTO

  ifneq ($(feature-libcrypto), 1)

    msg := $(warning No libcrypto.h found, disables jitted code injection, please install openssl-devel or libssl-dev);

    $(warning No libcrypto.h found, disables jitted code injection, please install openssl-devel or libssl-dev)

    NO_LIBCRYPTO := 1

  else

    CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT
@@ -797,7 +797,7 @@ endif 
ifndef NO_SLANG

  ifneq ($(feature-libslang), 1)

    ifneq ($(feature-libslang-include-subdir), 1)

      msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);

      $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev)

      NO_SLANG := 1

    else

      CFLAGS += -DHAVE_SLANG_INCLUDE_SUBDIR
@@ -815,7 +815,7 @@ ifdef GTK2 
  FLAGS_GTK2=$(CFLAGS) $(LDFLAGS) $(EXTLIBS) $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null)

  $(call feature_check,gtk2)

  ifneq ($(feature-gtk2), 1)

    msg := $(warning GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev);

    $(warning GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev)

    NO_GTK2 := 1

  else

    $(call feature_check,gtk2-infobar)
@@ -844,7 +844,7 @@ else 
  ifneq ($(feature-libperl), 1)

    CFLAGS += -DNO_LIBPERL

    NO_LIBPERL := 1

    msg := $(warning Missing perl devel files. Disabling perl scripting support, please install perl-ExtUtils-Embed/libperl-dev);

    $(warning Missing perl devel files. Disabling perl scripting support, please install perl-ExtUtils-Embed/libperl-dev)

  else

    LDFLAGS += $(PERL_EMBED_LDFLAGS)

    EXTLIBS += $(PERL_EMBED_LIBADD)
@@ -859,7 +859,7 @@ endif 
ifeq ($(feature-timerfd), 1)

  CFLAGS += -DHAVE_TIMERFD_SUPPORT

else

  msg := $(warning No timerfd support. Disables 'perf kvm stat live');

  $(warning No timerfd support. Disables 'perf kvm stat live')

endif



disable-python = $(eval $(disable-python_code))
@@ -893,7 +893,7 @@ else 
           PYTHON_EXTENSION_SUFFIX := $(shell $(PYTHON) -c 'from importlib import machinery; print(machinery.EXTENSION_SUFFIXES[0])')

           LANG_BINDINGS += $(obj-perf)python/perf$(PYTHON_EXTENSION_SUFFIX)

	 else

           msg := $(warning Missing python setuptools, the python binding won't be built, please install python3-setuptools or equivalent);

           $(warning Missing python setuptools, the python binding won't be built, please install python3-setuptools or equivalent)

         endif

         CFLAGS += -DHAVE_LIBPYTHON_SUPPORT

         $(call detected,CONFIG_LIBPYTHON)
@@ -952,7 +952,7 @@ ifdef BUILD_NONDISTRO 
  ifeq ($(feature-libbfd-buildid), 1)

    CFLAGS += -DHAVE_LIBBFD_BUILDID_SUPPORT

  else

    msg := $(warning Old version of libbfd/binutils things like PE executable profiling will not be available);

    $(warning Old version of libbfd/binutils things like PE executable profiling will not be available)

  endif

endif
@@ -984,7 +984,7 @@ ifndef NO_LZMA 
    EXTLIBS += -llzma

    $(call detected,CONFIG_LZMA)

  else

    msg := $(warning No liblzma found, disables xz kernel module decompression, please install xz-devel/liblzma-dev);

    $(warning No liblzma found, disables xz kernel module decompression, please install xz-devel/liblzma-dev)

    NO_LZMA := 1

  endif

endif
@@ -997,7 +997,7 @@ ifndef NO_LIBZSTD 
    EXTLIBS += -lzstd

    $(call detected,CONFIG_ZSTD)

  else

    msg := $(warning No libzstd found, disables trace compression, please install libzstd-dev[el] and/or set LIBZSTD_DIR);

    $(warning No libzstd found, disables trace compression, please install libzstd-dev[el] and/or set LIBZSTD_DIR)

    NO_LIBZSTD := 1

  endif

endif
@@ -1008,7 +1008,7 @@ ifndef NO_LIBCAP 
    EXTLIBS += -lcap

    $(call detected,CONFIG_LIBCAP)

  else

    msg := $(warning No libcap found, disables capability support, please install libcap-devel/libcap-dev);

    $(warning No libcap found, disables capability support, please install libcap-devel/libcap-dev)

    NO_LIBCAP := 1

  endif

endif
@@ -1021,11 +1021,11 @@ endif 


ifndef NO_LIBNUMA

  ifeq ($(feature-libnuma), 0)

    msg := $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev);

    $(warning No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev)

    NO_LIBNUMA := 1

  else

    ifeq ($(feature-numa_num_possible_cpus), 0)

      msg := $(warning Old numa library found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev >= 2.0.8);

      $(warning Old numa library found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev >= 2.0.8)

      NO_LIBNUMA := 1

    else

      CFLAGS += -DHAVE_LIBNUMA_SUPPORT
@@ -1080,7 +1080,7 @@ ifndef NO_LIBBABELTRACE 
    EXTLIBS += -lbabeltrace-ctf

    $(call detected,CONFIG_LIBBABELTRACE)

  else

    msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);

    $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev)

  endif

endif
@@ -1099,7 +1099,7 @@ endif 
ifndef NO_AUXTRACE

  ifeq ($(SRCARCH),x86)

    ifeq ($(feature-get_cpuid), 0)

      msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);

      $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc)

      NO_AUXTRACE := 1

    endif

  endif
@@ -1157,7 +1157,7 @@ ifndef NO_LIBPFM4 
    ASCIIDOC_EXTRA = -aHAVE_LIBPFM=1

    $(call detected,CONFIG_LIBPFM4)

  else

    msg := $(warning libpfm4 not found, disables libpfm4 support. Please install libpfm4-dev);

    $(warning libpfm4 not found, disables libpfm4 support. Please install libpfm4-dev)

  endif

endif
@@ -1175,7 +1175,7 @@ ifneq ($(NO_LIBTRACEEVENT),1) 
    CFLAGS += -DLIBTRACEEVENT_VERSION=$(LIBTRACEEVENT_VERSION_CPP)

    $(call detected,CONFIG_LIBTRACEEVENT)

  else

    dummy := $(error ERROR: libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel or build with NO_LIBTRACEEVENT=1)

    $(error ERROR: libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel or build with NO_LIBTRACEEVENT=1)

  endif



  $(call feature_check,libtracefs)

tools/perf/Makefile.perf

+2 −2
Original line number Diff line number Diff line
@@ -485,7 +485,7 @@ drm_hdr_dir := $(srctree)/tools/include/uapi/drm 
drm_ioctl_tbl := $(srctree)/tools/perf/trace/beauty/drm_ioctl.sh



# Create output directory if not already present

_dummy := $(shell [ -d '$(beauty_ioctl_outdir)' ] || mkdir -p '$(beauty_ioctl_outdir)')

$(shell [ -d '$(beauty_ioctl_outdir)' ] || mkdir -p '$(beauty_ioctl_outdir)')



$(drm_ioctl_array): $(drm_hdr_dir)/drm.h $(drm_hdr_dir)/i915_drm.h $(drm_ioctl_tbl)

	$(Q)$(SHELL) '$(drm_ioctl_tbl)' $(drm_hdr_dir) > $@
@@ -675,7 +675,7 @@ tests-coresight-targets-clean: 
all: shell_compatibility_test $(ALL_PROGRAMS) $(LANG_BINDINGS) $(OTHER_PROGRAMS) tests-coresight-targets



# Create python binding output directory if not already present

_dummy := $(shell [ -d '$(OUTPUT)python' ] || mkdir -p '$(OUTPUT)python')

$(shell [ -d '$(OUTPUT)python' ] || mkdir -p '$(OUTPUT)python')



$(OUTPUT)python/perf$(PYTHON_EXTENSION_SUFFIX): $(PYTHON_EXT_SRCS) $(PYTHON_EXT_DEPS) $(LIBPERF) $(LIBSUBCMD)

	$(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \

tools/perf/arch/arm64/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ sysprf := $(srctree)/tools/perf/arch/arm64/entry/syscalls/ 
systbl := $(sysprf)/mksyscalltbl



# Create output directory if not already present

_dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)')

$(shell [ -d '$(out)' ] || mkdir -p '$(out)')



$(header): $(sysdef) $(systbl)

	$(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@

tools/perf/arch/loongarch/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ sysprf := $(srctree)/tools/perf/arch/loongarch/entry/syscalls/ 
systbl := $(sysprf)/mksyscalltbl



# Create output directory if not already present

_dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)')

$(shell [ -d '$(out)' ] || mkdir -p '$(out)')



$(header): $(sysdef) $(systbl)

	$(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@

tools/perf/arch/mips/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ sysdef := $(sysprf)/syscall_n64.tbl 
systbl := $(sysprf)/mksyscalltbl



# Create output directory if not already present

_dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)')

$(shell [ -d '$(out)' ] || mkdir -p '$(out)')



$(header): $(sysdef) $(systbl)

	$(Q)$(SHELL) '$(systbl)' $(sysdef) > $@