Commit c2dbda07 authored by Ruben Wauters's avatar Ruben Wauters Committed by Jakub Kicinski
Browse files

ipv4: ip_tunnel: Replace strcpy use with strscpy 



Use of strcpy is decpreated, replaces the use of strcpy with strscpy as
recommended.

strscpy was chosen as it requires a NUL terminated non-padded string,
which is the case here.

I am aware there is an explicit bounds check above the second instance,
however using strscpy protects against buffer overflows in any future
code, and there is no good reason I can see to not use it.

I have also replaced the scrscpy above that had 3 params with the
version using 2 params. These are functionally equivalent, but it is
cleaner to have both using 2 params.

Signed-off-by: default avatarRuben Wauters <rubenru09@aol.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250501202935.46318-1-rubenru09@aol.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f267eeee

net/ipv4/ip_tunnel.c

+2 −2
Original line number Diff line number Diff line
@@ -243,11 +243,11 @@ static struct net_device *__ip_tunnel_create(struct net *net, 
	if (parms->name[0]) {

		if (!dev_valid_name(parms->name))

			goto failed;

		strscpy(name, parms->name, IFNAMSIZ);

		strscpy(name, parms->name);

	} else {

		if (strlen(ops->kind) > (IFNAMSIZ - 3))

			goto failed;

		strcpy(name, ops->kind);

		strscpy(name, ops->kind);

		strcat(name, "%d");

	}