Commit c2ef7a03 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Ulf Hansson
Browse files

mmc: sdio: Drop dev_pm_domain_detach() call 



Starting with commit f9950807 ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.

Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.

Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://lore.kernel.org/r/20250827101236.927313-1-claudiu.beznea.uj@bp.renesas.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 4b43f2bc

drivers/mmc/core/sdio_bus.c

+0 −3
Original line number Diff line number Diff line
@@ -200,7 +200,6 @@ static int sdio_bus_probe(struct device *dev) 
	atomic_dec(&func->card->sdio_funcs_probed);

	if (func->card->host->caps & MMC_CAP_POWER_OFF_CARD)

		pm_runtime_put_noidle(dev);

	dev_pm_domain_detach(dev, false);

	return ret;

}
@@ -231,8 +230,6 @@ static void sdio_bus_remove(struct device *dev) 
	/* Then undo the runtime PM settings in sdio_bus_probe() */

	if (func->card->host->caps & MMC_CAP_POWER_OFF_CARD)

		pm_runtime_put_sync(dev);



	dev_pm_domain_detach(dev, false);

}



static const struct dev_pm_ops sdio_bus_pm_ops = {