Commit c3194949 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

usb: typec: intel_pmc_mux: Don't leak the ACPI device reference count 



When acpi_dev_get_memory_resources() fails, the reference count is
left bumped. Drop it as it's done in the other error paths.

Fixes: 43d596e3 ("usb: typec: intel_pmc_mux: Check the port status before connect")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230102202933.15968-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ccb0beb4

drivers/usb/typec/mux/intel_pmc_mux.c

+3 −1
Original line number Diff line number Diff line
@@ -614,8 +614,10 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) 


	INIT_LIST_HEAD(&resource_list);

	ret = acpi_dev_get_memory_resources(adev, &resource_list);

	if (ret < 0)

	if (ret < 0) {

		acpi_dev_put(adev);

		return ret;

	}



	rentry = list_first_entry_or_null(&resource_list, struct resource_entry, node);

	if (rentry)