Commit c3441488 authored by Louis-Alexis Eyraud's avatar Louis-Alexis Eyraud Committed by Chun-Kuang Hu
Browse files

drm/mediatek: mtk_hdmi: Fix inverted parameters in some regmap_update_bits calls 



In mtk_hdmi driver, a recent change replaced custom register access
function calls by regmap ones, but two replacements by regmap_update_bits
were done incorrectly, because original offset and mask parameters were
inverted, so fix them.

Fixes: d6e25b35 ("drm/mediatek: hdmi: Use regmap instead of iomem for main registers")
Signed-off-by: default avatarLouis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20250818-mt8173-fix-hdmi-issue-v1-1-55aff9b0295d@collabora.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 1f403699

drivers/gpu/drm/mediatek/mtk_hdmi.c

+4 −4
Original line number Diff line number Diff line
@@ -182,8 +182,8 @@ static inline struct mtk_hdmi *hdmi_ctx_from_bridge(struct drm_bridge *b) 


static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black)

{

	regmap_update_bits(hdmi->regs, VIDEO_SOURCE_SEL,

			   VIDEO_CFG_4, black ? GEN_RGB : NORMAL_PATH);

	regmap_update_bits(hdmi->regs, VIDEO_CFG_4,

			   VIDEO_SOURCE_SEL, black ? GEN_RGB : NORMAL_PATH);

}



static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable)
@@ -310,8 +310,8 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer, 


static void mtk_hdmi_hw_send_aud_packet(struct mtk_hdmi *hdmi, bool enable)

{

	regmap_update_bits(hdmi->regs, AUDIO_PACKET_OFF,

			   GRL_SHIFT_R2, enable ? 0 : AUDIO_PACKET_OFF);

	regmap_update_bits(hdmi->regs, GRL_SHIFT_R2,

			   AUDIO_PACKET_OFF, enable ? 0 : AUDIO_PACKET_OFF);

}



static void mtk_hdmi_hw_config_sys(struct mtk_hdmi *hdmi)