Commit c378c497 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: drv-net: devmem: flip the direction of Tx tests 



The Device Under Test should always be the local system.
While the Rx test gets this right the Tx test is sending
from remote to local. So Tx of DMABUF memory happens on remote.

These tests never run in NIPA since we don't have a compatible
device so we haven't caught this.

Reviewed-by: default avatarJoe Damato <joe@dama.to>
Reviewed-by: default avatarMina Almasry <almasrymina@google.com>
Acked-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250811231334.561137-6-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6e9a12f8

tools/testing/selftests/drivers/net/hw/devmem.py

+6 −6
Original line number Diff line number Diff line
@@ -42,9 +42,9 @@ def check_tx(cfg) -> None: 
    port = rand_port()

    listen_cmd = f"socat -U - TCP{cfg.addr_ipver}-LISTEN:{port}"



    with bkg(listen_cmd) as socat:

        wait_port_listen(port)

        cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_remote} -f {cfg.ifname} -s {cfg.addr} -p {port}", host=cfg.remote, shell=True)

    with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as socat:

        wait_port_listen(port, host=cfg.remote)

        cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_local} -f {cfg.ifname} -s {cfg.remote_addr} -p {port}", shell=True)



    ksft_eq(socat.stdout.strip(), "hello\nworld")
@@ -56,9 +56,9 @@ def check_tx_chunks(cfg) -> None: 
    port = rand_port()

    listen_cmd = f"socat -U - TCP{cfg.addr_ipver}-LISTEN:{port}"



    with bkg(listen_cmd, exit_wait=True) as socat:

        wait_port_listen(port)

        cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_remote} -f {cfg.ifname} -s {cfg.addr} -p {port} -z 3", host=cfg.remote, shell=True)

    with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as socat:

        wait_port_listen(port, host=cfg.remote)

        cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_local} -f {cfg.ifname} -s {cfg.remote_addr} -p {port} -z 3", shell=True)



    ksft_eq(socat.stdout.strip(), "hello\nworld")