Unverified Commit c37adf34 authored by Onur Özkan's avatar Onur Özkan Committed by Christian Brauner
Browse files

rust: file: use to_result for error handling 



Simplifies error handling by replacing the manual check
of the return value with the `to_result` helper.

Signed-off-by: default avatarOnur Özkan <work@onurozkan.dev>
Link: https://lore.kernel.org/20250821091001.28563-1-work@onurozkan.dev


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 76196742

rust/kernel/fs/file.rs

+3 −4
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ 
use crate::{

    bindings,

    cred::Credential,

    error::{code::*, Error, Result},

    error::{code::*, to_result, Error, Result},

    sync::aref::{ARef, AlwaysRefCounted},

    types::{NotThreadSafe, Opaque},

};
@@ -399,9 +399,8 @@ impl FileDescriptorReservation { 
    pub fn get_unused_fd_flags(flags: u32) -> Result<Self> {

        // SAFETY: FFI call, there are no safety requirements on `flags`.

        let fd: i32 = unsafe { bindings::get_unused_fd_flags(flags) };

        if fd < 0 {

            return Err(Error::from_errno(fd));

        }

        to_result(fd)?;



        Ok(Self {

            fd: fd as u32,

            _not_send: NotThreadSafe,