Commit c3a0b61e authored by Xianwei Zhao's avatar Xianwei Zhao Committed by Linus Walleij
Browse files

pinctrl: meson: fix pin input property for a4 



The register of pin input attribute means the opposite.
value of reigster meaning is 1 for input and 0 for output.
So fix it.

Fixes: 6e9be3ab ("pinctrl: Add driver support for Amlogic SoCs")
Signed-off-by: default avatarXianwei Zhao <xianwei.zhao@amlogic.com>
Link: https://lore.kernel.org/20250303-fix-a4-pinctl-v1-1-6579888b4272@amlogic.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 75f87f5d

drivers/pinctrl/meson/pinctrl-amlogic-a4.c

+3 −3
Original line number Diff line number Diff line
@@ -775,7 +775,7 @@ static int aml_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio) 
	if (ret)

		return ret;



	return BIT(bit) & val ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN;

	return BIT(bit) & val ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT;

}



static int aml_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio)
@@ -785,7 +785,7 @@ static int aml_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) 


	aml_gpio_calc_reg_and_bit(bank, AML_REG_DIR, gpio, &reg, &bit);



	return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), 0);

	return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), BIT(bit));

}



static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio,
@@ -796,7 +796,7 @@ static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, 
	int ret;



	aml_gpio_calc_reg_and_bit(bank, AML_REG_DIR, gpio, &reg, &bit);

	ret = regmap_update_bits(bank->reg_gpio, reg, BIT(bit), BIT(bit));

	ret = regmap_update_bits(bank->reg_gpio, reg, BIT(bit), 0);

	if (ret < 0)

		return ret;