Commit c3a11c0e authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French
Browse files

cifs: delete unnecessary NULL checks in cifs_chan_update_iface() 



We return early if "iface" is NULL so there is no need to check here.
Delete those checks.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 8a3c4e44

fs/smb/client/sess.c

+11 −15
Original line number Diff line number Diff line
@@ -467,16 +467,13 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server) 
		kref_put(&old_iface->refcount, release_iface);

	} else if (!chan_index) {

		/* special case: update interface for primary channel */

		if (iface) {

		cifs_dbg(FYI, "referencing primary channel iface: %pIS\n",

			 &iface->sockaddr);

		iface->num_channels++;

		iface->weight_fulfilled++;

	}

	}

	spin_unlock(&ses->iface_lock);



	if (iface) {

	spin_lock(&ses->chan_lock);

	chan_index = cifs_ses_get_chan_index(ses, server);

	if (chan_index == CIFS_INVAL_CHAN_INDEX) {
@@ -486,7 +483,6 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server) 


	ses->chans[chan_index].iface = iface;

	spin_unlock(&ses->chan_lock);

	}



	return rc;

}