Commit c3bb3295 authored by Corey Minyard's avatar Corey Minyard
Browse files

ipmi:si: Use a long timeout when the BMC is misbehaving 



If the driver goes into HOSED state, don't reset the timeout to the
short timeout in the timeout handler.

Reported-by: default avatarIgor Raits <igor@gooddata.com>
Closes: https://lore.kernel.org/linux-acpi/CAK8fFZ58fidGUCHi5WFX0uoTPzveUUDzT=k=AAm4yWo3bAuCFg@mail.gmail.com/


Fixes: bc3a9d21 ("ipmi:si: Gracefully handle if the BMC is non-functional")
Cc: stable@vger.kernel.org # 4.18
Signed-off-by: default avatarCorey Minyard <corey@minyard.net>
parent 52c9ee20

drivers/char/ipmi/ipmi_si_intf.c

+3 −1
Original line number Diff line number Diff line
@@ -1119,7 +1119,9 @@ static void smi_timeout(struct timer_list *t) 
		     * SI_USEC_PER_JIFFY);

	smi_result = smi_event_handler(smi_info, time_diff);



	if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) {

	if (smi_info->si_state == SI_HOSED) {

		timeout = jiffies + SI_TIMEOUT_HOSED;

	} else if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) {

		/* Running with interrupts, only do long timeouts. */

		timeout = jiffies + SI_TIMEOUT_JIFFIES;

		smi_inc_stat(smi_info, long_timeouts);