Unverified Commit c3c4f22b authored by Devyn Liu's avatar Devyn Liu Committed by Mark Brown
Browse files

spi: hisi-kunpeng: Add validation for the minimum value of speed_hz 



The speed specified by the user is used to calculate the clk_div based
on the max_speed_hz in hisi_calc_effective_speed.  A very low speed
value can lead to a clk_div larger than the variable range. Avoid this
by setting the min_speed_hz so that such a small speed value is
rejected.  __spi_validate() in spi.c will return -EINVAL for the
specified speed_hz lower than min_speed_hz.

Signed-off-by: default avatarDevyn Liu <liudingyuan@huawei.com>
Reviewed-by: default avatarJay Fang <f.fangjian@huawei.com>
Link: https://patch.msgid.link/20240730032040.3156393-2-liudingyuan@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8400291e

drivers/spi/spi-hisi-kunpeng.c

+1 −0
Original line number Diff line number Diff line
@@ -495,6 +495,7 @@ static int hisi_spi_probe(struct platform_device *pdev) 
	host->transfer_one = hisi_spi_transfer_one;

	host->handle_err = hisi_spi_handle_err;

	host->dev.fwnode = dev->fwnode;

	host->min_speed_hz = DIV_ROUND_UP(host->max_speed_hz, CLK_DIV_MAX);



	hisi_spi_hw_init(hs);