Unverified Commit c40897f4 authored by Kees Cook's avatar Kees Cook Committed by Mark Brown
Browse files

spi: mchp-pci1xxxx: Annotate struct pci1xxxx_spi with __counted_by 

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct pci1xxxx_spi.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci



Cc: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230922175322.work.170-kees@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 21f252cd

drivers/spi/spi-pci1xxxx.c

+1 −1
Original line number Diff line number Diff line
@@ -77,7 +77,7 @@ struct pci1xxxx_spi { 
	struct pci_dev *dev;

	u8 total_hw_instances;

	void __iomem *reg_base;

	struct pci1xxxx_spi_internal *spi_int[];

	struct pci1xxxx_spi_internal *spi_int[] __counted_by(total_hw_instances);

};



static const struct pci_device_id pci1xxxx_spi_pci_id_table[] = {