Commit c451715d authored Feb 19, 2025 by Thorsten Blum Committed by Jakub Kicinski Feb 21, 2025

net/rds: Replace deprecated strncpy() with strscpy_pad()

strncpy() is deprecated for NUL-terminated destination buffers. Use
strscpy_pad() instead and remove the manual NUL-termination.

Compile-tested only.

Link: https://github.com/KSPP/linux/issues/90


Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Kees Cook <kees@kernel.org>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Tested-by: Allison Henderson <allison.henderson@oracle.com>
Link: https://patch.msgid.link/20250219224730.73093-2-thorsten.blum@linux.dev


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 376cd9a2

net/rds/stats.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -89,8 +89,7 @@ void rds_stats_info_copy(struct rds_info_iterator *iter,

		for (i = 0; i < nr; i++) {
		BUG_ON(strlen(names[i]) >= sizeof(ctr.name));
		strncpy(ctr.name, names[i], sizeof(ctr.name) - 1);
		ctr.name[sizeof(ctr.name) - 1] = '\0';
		strscpy_pad(ctr.name, names[i]);
		ctr.value = values[i];

		rds_info_copy(iter, &ctr, sizeof(ctr));