Commit c47f7ff0 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: pca953x: Utilise dev_err_probe() where it makes sense 



At least in pca953x_irq_setup() we may use dev_err_probe().

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 53c59d66

drivers/gpio/gpio-pca953x.c

+3 −5
Original line number Diff line number Diff line
@@ -926,6 +926,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid) 
static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)

{

	struct i2c_client *client = chip->client;

	struct device *dev = &client->dev;

	DECLARE_BITMAP(reg_direction, MAX_LINE);

	DECLARE_BITMAP(irq_stat, MAX_LINE);

	struct gpio_irq_chip *girq;
@@ -974,11 +975,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) 
					NULL, pca953x_irq_handler,

					IRQF_ONESHOT | IRQF_SHARED,

					dev_name(&client->dev), chip);

	if (ret) {

		dev_err(&client->dev, "failed to request irq %d\n",

			client->irq);

		return ret;

	}

	if (ret)

		return dev_err_probe(dev, client->irq, "failed to request irq\n");



	return 0;

}