Commit c4b7779a authored by Zhen Lei's avatar Zhen Lei Committed by Mauro Carvalho Chehab
Browse files

media: nuvoton: Fix an error check in npcm_video_ece_init() 



When function of_find_device_by_node() fails, it returns NULL instead of
an error code. So the corresponding error check logic should be modified
to check whether the return value is NULL and set the error code to be
returned as -ENODEV.

Fixes: 46c15a4f ("media: nuvoton: Add driver for NPCM video capture and encoding engine")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20241015014053.669-1-thunder.leizhen@huawei.com


Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent c36b9ad1

drivers/media/platform/nuvoton/npcm-video.c

+2 −2
Original line number Diff line number Diff line
@@ -1665,9 +1665,9 @@ static int npcm_video_ece_init(struct npcm_video *video) 
		dev_info(dev, "Support HEXTILE pixel format\n");



		ece_pdev = of_find_device_by_node(ece_node);

		if (IS_ERR(ece_pdev)) {

		if (!ece_pdev) {

			dev_err(dev, "Failed to find ECE device\n");

			return PTR_ERR(ece_pdev);

			return -ENODEV;

		}

		of_node_put(ece_node);