Commit c4bdef8b authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

hinic3: Fix NULL vs IS_ERR() check in hinic3_alloc_rxqs_res() 



The page_pool_create() function never returns NULL, it returns
error pointers.  Update the check to match.

Fixes: 73f37a7e ("hinic3: Queue pair resource initialization")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/aMvUywhgbmO1kH3Z@stanley.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 17f1b771

drivers/net/ethernet/huawei/hinic3/hinic3_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -414,7 +414,7 @@ int hinic3_alloc_rxqs_res(struct net_device *netdev, u16 num_rq, 
		pp_params.dma_dir = DMA_FROM_DEVICE;

		pp_params.max_len = PAGE_SIZE;

		rqres->page_pool = page_pool_create(&pp_params);

		if (!rqres->page_pool) {

		if (IS_ERR(rqres->page_pool)) {

			netdev_err(netdev, "Failed to create rxq%d page pool\n",

				   idx);

			goto err_free_cqe;