Unverified Commit c4c9c89c authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Christian Brauner
Browse files

ntfs3: Remove reset_log_file() 



This function has no callers (which will be why nobody noticed that
the page wasn't being unlocked).

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 663459c8

fs/ntfs3/inode.c

+0 −39
Original line number Diff line number Diff line
@@ -1008,45 +1008,6 @@ int ntfs_write_end(struct file *file, struct address_space *mapping, loff_t pos, 
	return err;

}



int reset_log_file(struct inode *inode)

{

	int err;

	loff_t pos = 0;

	u32 log_size = inode->i_size;

	struct address_space *mapping = inode->i_mapping;



	for (;;) {

		u32 len;

		void *kaddr;

		struct page *page;



		len = pos + PAGE_SIZE > log_size ? (log_size - pos) : PAGE_SIZE;



		err = block_write_begin(mapping, pos, len, &page,

					ntfs_get_block_write_begin);

		if (err)

			goto out;



		kaddr = kmap_atomic(page);

		memset(kaddr, -1, len);

		kunmap_atomic(kaddr);

		flush_dcache_page(page);



		err = block_write_end(NULL, mapping, pos, len, len, page, NULL);

		if (err < 0)

			goto out;

		pos += len;



		if (pos >= log_size)

			break;

		balance_dirty_pages_ratelimited(mapping);

	}

out:

	mark_inode_dirty_sync(inode);



	return err;

}



int ntfs3_write_inode(struct inode *inode, struct writeback_control *wbc)

{

	return _ni_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL);

fs/ntfs3/ntfs_fs.h

+0 −1
Original line number Diff line number Diff line
@@ -708,7 +708,6 @@ int indx_update_dup(struct ntfs_inode *ni, struct ntfs_sb_info *sbi, 
struct inode *ntfs_iget5(struct super_block *sb, const struct MFT_REF *ref,

			 const struct cpu_str *name);

int ntfs_set_size(struct inode *inode, u64 new_size);

int reset_log_file(struct inode *inode);

int ntfs_get_block(struct inode *inode, sector_t vbn,

		   struct buffer_head *bh_result, int create);

int ntfs_write_begin(struct file *file, struct address_space *mapping,