Commit c4d13222 authored by Chao Yu's avatar Chao Yu Committed by Theodore Ts'o
Browse files

ext4: fix to check return value of freeze_bdev() in ext4_shutdown() 



freeze_bdev() can fail due to a lot of reasons, it needs to check its
reason before later process.

Fixes: 783d9485 ("ext4: add EXT4_IOC_GOINGDOWN ioctl")
Cc: stable@kernel.org
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20230606073203.1310389-1-chao@kernel.org


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent f3c1c42e

fs/ext4/ioctl.c

+4 −1
Original line number Diff line number Diff line
@@ -797,6 +797,7 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg) 
{

	struct ext4_sb_info *sbi = EXT4_SB(sb);

	__u32 flags;

	int ret;



	if (!capable(CAP_SYS_ADMIN))

		return -EPERM;
@@ -815,7 +816,9 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg) 


	switch (flags) {

	case EXT4_GOING_FLAGS_DEFAULT:

		freeze_bdev(sb->s_bdev);

		ret = freeze_bdev(sb->s_bdev);

		if (ret)

			return ret;

		set_bit(EXT4_FLAGS_SHUTDOWN, &sbi->s_ext4_flags);

		thaw_bdev(sb->s_bdev);

		break;