Unverified Commit c4d7d907 authored by Mohammed Anees's avatar Mohammed Anees Committed by Christian Brauner
Browse files

fs:aio: Remove TODO comment suggesting hash or array usage in io_cancel() 



The comment suggests a hash or array approach to
store the active requests. Currently it iterates
through all the active requests and when found
deletes the requested request, in the linked list.
However io_cancel() isn’t a frequently used operation,
and optimizing it wouldn’t bring a substantial benefit
to real users and the increased complexity of maintaining
a hashtable for this would be significant and will slow
down other operation. Therefore remove this TODO
to avoid people spending time improving this.

Signed-off-by: default avatarMohammed Anees <pvmohammedanees2003@gmail.com>
Link: https://lore.kernel.org/r/20241112113906.15825-1-pvmohammedanees2003@gmail.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 1c82587c

fs/aio.c

+0 −1
Original line number Diff line number Diff line
@@ -2191,7 +2191,6 @@ SYSCALL_DEFINE3(io_cancel, aio_context_t, ctx_id, struct iocb __user *, iocb, 
		return -EINVAL;



	spin_lock_irq(&ctx->ctx_lock);

	/* TODO: use a hash or array, this sucks. */

	list_for_each_entry(kiocb, &ctx->active_reqs, ki_list) {

		if (kiocb->ki_res.obj == obj) {

			ret = kiocb->ki_cancel(&kiocb->rw);