Commit c501062b authored by Yongqiang Liu's avatar Yongqiang Liu Committed by Sean Christopherson
Browse files

KVM: SVM: Remove unnecessary GFP_KERNEL_ACCOUNT in svm_set_nested_state() 



The fixed size temporary variables vmcb_control_area and vmcb_save_area
allocated in svm_set_nested_state() are released when the function exits.
Meanwhile, svm_set_nested_state() also have vcpu mutex held to avoid
massive concurrency allocation, so we don't need to set GFP_KERNEL_ACCOUNT.

Signed-off-by: default avatarYongqiang Liu <liuyongqiang13@huawei.com>
Link: https://lore.kernel.org/r/20240821112737.3649937-1-liuyongqiang13@huawei.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 47ac09b9

arch/x86/kvm/svm/nested.c

+2 −2
Original line number Diff line number Diff line
@@ -1693,8 +1693,8 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu, 
		return -EINVAL;



	ret  = -ENOMEM;

	ctl  = kzalloc(sizeof(*ctl),  GFP_KERNEL_ACCOUNT);

	save = kzalloc(sizeof(*save), GFP_KERNEL_ACCOUNT);

	ctl  = kzalloc(sizeof(*ctl),  GFP_KERNEL);

	save = kzalloc(sizeof(*save), GFP_KERNEL);

	if (!ctl || !save)

		goto out_free;