Commit c5170683 authored by Tomer Tayar's avatar Tomer Tayar Committed by Oded Gabbay
Browse files

accel/habanalabs: keep explicit size of reserved memory for FW 



The reserved memory for FW is currently saved in an ASIC property in
units of MB, just like the value that comes from FW.
Except the fact that it is not clear from the property's name, it means
also that a calculation to actual size is required everywhere that it is
used.
Modify the property to hold the size in bytes.

Signed-off-by: default avatarTomer Tayar <ttayar@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Reviewed-by: default avatarCarl Vanderlip <quic_carlv@quicinc.com>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent db45bbdd

drivers/accel/habanalabs/common/firmware_if.c

+1 −1
Original line number Diff line number Diff line
@@ -2724,7 +2724,7 @@ static int hl_fw_dynamic_init_cpu(struct hl_device *hdev, 


	if (hdev->asic_prop.support_dynamic_resereved_fw_size)

		hdev->asic_prop.reserved_fw_mem_size =

				le32_to_cpu(fw_loader->dynamic_loader.comm_desc.rsvd_mem_size_mb);

			le32_to_cpu(fw_loader->dynamic_loader.comm_desc.rsvd_mem_size_mb) * SZ_1M;



	if (!(hdev->fw_components & FW_TYPE_BOOT_CPU)) {

		struct lkd_fw_binning_info *binning_info;

drivers/accel/habanalabs/common/habanalabs.h

+1 −1
Original line number Diff line number Diff line
@@ -650,7 +650,7 @@ struct hl_hints_range { 
 * @glbl_err_max_cause_num: global err max cause number.

 * @hbw_flush_reg: register to read to generate HBW flush. value of 0 means HBW flush is

 *                 not supported.

 * @reserved_fw_mem_size: size in MB of dram memory reserved for FW.

 * @reserved_fw_mem_size: size of dram memory reserved for FW.

 * @collective_first_sob: first sync object available for collective use

 * @collective_first_mon: first monitor available for collective use

 * @sync_stream_first_sob: first sync object available for sync stream use