Unverified Commit c5408d81 authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Fix memory leak in avs_register_i2s_test_boards() 



Caller is responsible for freeing array allocated with
parse_int_array().

Found out by Coverity.

Fixes: 7d859189 ("ASoC: Intel: avs: Allow to specify custom configurations with i2s_test")
Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20260407085459.400628-1-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b33b340e

sound/soc/intel/avs/board_selection.c

+6 −3
Original line number Diff line number Diff line
@@ -520,7 +520,8 @@ static int avs_register_i2s_test_boards(struct avs_dev *adev) 
	if (num_elems > max_ssps) {

		dev_err(adev->dev, "board supports only %d SSP, %d specified\n",

			max_ssps, num_elems);

		return -EINVAL;

		ret = -EINVAL;

		goto exit;

	}



	for (ssp_port = 0; ssp_port < num_elems; ssp_port++) {
@@ -528,11 +529,13 @@ static int avs_register_i2s_test_boards(struct avs_dev *adev) 
		for_each_set_bit(tdm_slot, &tdm_slots, 16) {

			ret = avs_register_i2s_test_board(adev, ssp_port, tdm_slot);

			if (ret)

				return ret;

				goto exit;

		}

	}



	return 0;

exit:

	kfree(array);

	return ret;

}



static int avs_register_i2s_board(struct avs_dev *adev, struct snd_soc_acpi_mach *mach)