Commit c55017a0 authored by Mika Westerberg's avatar Mika Westerberg
Browse files

thunderbolt: Debug log an invalid config space reply just once 



These can mess up the debug log if a router does not implement the
config space register blocks fully and we are reading registers through
debugfs. To avoid this, just log it once.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent cfdfdb1a

drivers/thunderbolt/ctl.c

+5 −2
Original line number Diff line number Diff line
@@ -70,6 +70,9 @@ struct tb_ctl { 
#define tb_ctl_dbg(ctl, format, arg...) \

	dev_dbg(&(ctl)->nhi->pdev->dev, format, ## arg)



#define tb_ctl_dbg_once(ctl, format, arg...) \

	dev_dbg_once(&(ctl)->nhi->pdev->dev, format, ## arg)



static DECLARE_WAIT_QUEUE_HEAD(tb_cfg_request_cancel_queue);

/* Serializes access to request kref_get/put */

static DEFINE_MUTEX(tb_cfg_request_lock);
@@ -279,7 +282,7 @@ static void tb_cfg_print_error(struct tb_ctl *ctl, enum tb_cfg_space space, 
		 * Invalid cfg_space/offset/length combination in

		 * cfg_read/cfg_write.

		 */

		tb_ctl_dbg(ctl, "%llx:%x: invalid config space (%u) or offset\n",

		tb_ctl_dbg_once(ctl, "%llx:%x: invalid config space (%u) or offset\n",

				res->response_route, res->response_port, space);

		return;

	case TB_CFG_ERROR_NO_SUCH_PORT: