Commit c553c412 authored by Philipp Stanner's avatar Philipp Stanner Committed by Takashi Iwai
Browse files

ALSA: trident: Use pure devres PCI 



pci_request_regions() is a hybrid function which becomes managed if
pcim_enable_device() was called before. This hybrid nature is deprecated
and should not be used anymore.

In addition, the request function's name parameter should describe the
driver, not the device.

Replace pci_request_regions() with the always-managed function
pcim_request_all_regions().

Signed-off-by: default avatarPhilipp Stanner <phasta@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250423075346.45907-17-phasta@kernel.org
parent 20db879a

sound/pci/trident/trident_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3533,7 +3533,7 @@ int snd_trident_create(struct snd_card *card, 
	trident->midi_port = TRID_REG(trident, T4D_MPU401_BASE);

	pci_set_master(pci);



	err = pci_request_regions(pci, "Trident Audio");

	err = pcim_request_all_regions(pci, "Trident Audio");

	if (err < 0)

		return err;

	trident->port = pci_resource_start(pci, 0);