Commit c57c7649 authored by Advait Dhamorikar's avatar Advait Dhamorikar Committed by Leon Romanovsky
Browse files

RDMA/erdma: Fix opcode conditional check 



Fix conditional if else check by checking with wr->opcode.
The indicated dead code may have performed some action; that
action will never occur as op is pre-assigned a different value.

Fixes: 999a0a2e ("RDMA/erdma: Support UD QPs and UD WRs")
Signed-off-by: default avatarAdvait Dhamorikar <advaitdhamorikar@gmail.com>
Link: https://patch.msgid.link/20241219043939.10344-1-advaitdhamorikar@gmail.com


Reviewed-by: default avatarCheng Xu <chengyou@linux.alibaba.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent a3cbf68c

drivers/infiniband/hw/erdma/erdma_qp.c

+1 −1
Original line number Diff line number Diff line
@@ -406,7 +406,7 @@ static void init_send_sqe_rc(struct erdma_qp *qp, struct erdma_send_sqe_rc *sqe, 
	if (wr->opcode == IB_WR_SEND_WITH_IMM) {

		op = ERDMA_OP_SEND_WITH_IMM;

		sqe->imm_data = wr->ex.imm_data;

	} else if (op == IB_WR_SEND_WITH_INV) {

	} else if (wr->opcode == IB_WR_SEND_WITH_INV) {

		op = ERDMA_OP_SEND_WITH_INV;

		sqe->invalid_stag = cpu_to_le32(wr->ex.invalidate_rkey);

	}