Commit c5cc2a27 authored by Mateusz Polchlopek's avatar Mateusz Polchlopek Committed by Tony Nguyen
Browse files

ice: remove invalid parameter of equalizer 



It occurred that in the commit 70838938 ("ice: Implement driver
functionality to dump serdes equalizer values") the invalid DRATE parameter
for reading has been added. The output of the command:

  $ ethtool -d <ethX>

returns the garbage value in the place where DRATE value should be
stored.

Remove mentioned parameter to prevent return of corrupted data to
userspace.

Fixes: 70838938 ("ice: Implement driver functionality to dump serdes equalizer values")
Signed-off-by: default avatarMateusz Polchlopek <mateusz.polchlopek@intel.com>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 18625e26

drivers/net/ethernet/intel/ice/ice_adminq_cmd.h

+0 −1
Original line number Diff line number Diff line
@@ -1498,7 +1498,6 @@ struct ice_aqc_dnl_equa_param { 
#define ICE_AQC_RX_EQU_POST1 (0x12 << ICE_AQC_RX_EQU_SHIFT)

#define ICE_AQC_RX_EQU_BFLF (0x13 << ICE_AQC_RX_EQU_SHIFT)

#define ICE_AQC_RX_EQU_BFHF (0x14 << ICE_AQC_RX_EQU_SHIFT)

#define ICE_AQC_RX_EQU_DRATE (0x15 << ICE_AQC_RX_EQU_SHIFT)

#define ICE_AQC_RX_EQU_CTLE_GAINHF (0x20 << ICE_AQC_RX_EQU_SHIFT)

#define ICE_AQC_RX_EQU_CTLE_GAINLF (0x21 << ICE_AQC_RX_EQU_SHIFT)

#define ICE_AQC_RX_EQU_CTLE_GAINDC (0x22 << ICE_AQC_RX_EQU_SHIFT)

drivers/net/ethernet/intel/ice/ice_ethtool.c

+0 −1
Original line number Diff line number Diff line
@@ -710,7 +710,6 @@ static int ice_get_tx_rx_equa(struct ice_hw *hw, u8 serdes_num, 
		{ ICE_AQC_RX_EQU_POST1, rx, &ptr->rx_equ_post1 },

		{ ICE_AQC_RX_EQU_BFLF, rx, &ptr->rx_equ_bflf },

		{ ICE_AQC_RX_EQU_BFHF, rx, &ptr->rx_equ_bfhf },

		{ ICE_AQC_RX_EQU_DRATE, rx, &ptr->rx_equ_drate },

		{ ICE_AQC_RX_EQU_CTLE_GAINHF, rx, &ptr->rx_equ_ctle_gainhf },

		{ ICE_AQC_RX_EQU_CTLE_GAINLF, rx, &ptr->rx_equ_ctle_gainlf },

		{ ICE_AQC_RX_EQU_CTLE_GAINDC, rx, &ptr->rx_equ_ctle_gaindc },

drivers/net/ethernet/intel/ice/ice_ethtool.h

+0 −1
Original line number Diff line number Diff line
@@ -15,7 +15,6 @@ struct ice_serdes_equalization_to_ethtool { 
	int rx_equ_post1;

	int rx_equ_bflf;

	int rx_equ_bfhf;

	int rx_equ_drate;

	int rx_equ_ctle_gainhf;

	int rx_equ_ctle_gainlf;

	int rx_equ_ctle_gaindc;