Commit c5f71916 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/rw: always clear ->bytes_done on io_async_rw setup 



A previous commit mistakenly moved the clearing of the in-progress byte
count into the section that's dependent on having a cached iovec or not,
but it should be cleared for any IO. If not, then extra bytes may be
added at IO completion time, causing potentially weird behavior like
over-reporting the amount of IO done.

Fixes: d7f11616 ("io_uring/rw: Allocate async data through helper")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202412271132.a09c3500-lkp@intel.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 21adbcaa

io_uring/rw.c

+1 −1
Original line number Diff line number Diff line
@@ -228,8 +228,8 @@ static int io_rw_alloc_async(struct io_kiocb *req) 
		kasan_mempool_unpoison_object(rw->free_iovec,

					      rw->free_iov_nr * sizeof(struct iovec));

		req->flags |= REQ_F_NEED_CLEANUP;

		rw->bytes_done = 0;

	}

	rw->bytes_done = 0;

	return 0;

}