Unverified Commit c65174fd authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

spi: pxa2xx: Utilise temporary variable for struct device 



We have a temporary variable to keep a pointer to struct device.
Utilise it where it makes sense.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://msgid.link/r/20240530151117.1130792-6-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c1b93986

drivers/spi/spi-pxa2xx.c

+11 −10
Original line number Diff line number Diff line
@@ -1606,13 +1606,13 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) 
		}

	}



	pm_runtime_set_autosuspend_delay(&pdev->dev, 50);

	pm_runtime_use_autosuspend(&pdev->dev);

	pm_runtime_set_active(&pdev->dev);

	pm_runtime_enable(&pdev->dev);

	pm_runtime_set_autosuspend_delay(dev, 50);

	pm_runtime_use_autosuspend(dev);

	pm_runtime_set_active(dev);

	pm_runtime_enable(dev);



	/* Register with the SPI framework */

	platform_set_drvdata(pdev, drv_data);

	dev_set_drvdata(dev, drv_data);

	status = spi_register_controller(controller);

	if (status) {

		dev_err_probe(dev, status, "problem registering SPI controller\n");
@@ -1622,7 +1622,7 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) 
	return status;



out_error_pm_runtime_enabled:

	pm_runtime_disable(&pdev->dev);

	pm_runtime_disable(dev);



out_error_clock_enabled:

	clk_disable_unprepare(ssp->clk);
@@ -1636,10 +1636,11 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) 


static void pxa2xx_spi_remove(struct platform_device *pdev)

{

	struct driver_data *drv_data = platform_get_drvdata(pdev);

	struct device *dev = &pdev->dev;

	struct driver_data *drv_data = dev_get_drvdata(dev);

	struct ssp_device *ssp = drv_data->ssp;



	pm_runtime_get_sync(&pdev->dev);

	pm_runtime_get_sync(dev);



	spi_unregister_controller(drv_data->controller);
@@ -1651,8 +1652,8 @@ static void pxa2xx_spi_remove(struct platform_device *pdev) 
	if (drv_data->controller_info->enable_dma)

		pxa2xx_spi_dma_release(drv_data);



	pm_runtime_put_noidle(&pdev->dev);

	pm_runtime_disable(&pdev->dev);

	pm_runtime_put_noidle(dev);

	pm_runtime_disable(dev);



	/* Release IRQ */

	free_irq(ssp->irq, drv_data);