Commit c6878e47 authored by José Roberto de Souza's avatar José Roberto de Souza
Browse files

drm/xe: Fix crash in trace_dma_fence_init() 



trace_dma_fence_init() uses dma_fence_ops functions
like get_driver_name() and get_timeline_name() to generate trace
information but the Xe KMD implementation of those functions makes
use of xe_hw_fence_ctx that was being set after dma_fence_init().

So here just inverting the order to fix the crash.

Fixes: dd08ebf6 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240124171830.95774-1-jose.souza@intel.com
parent 439987f6

drivers/gpu/drm/xe/xe_hw_fence.c

+3 −3
Original line number Diff line number Diff line
@@ -217,13 +217,13 @@ struct xe_hw_fence *xe_hw_fence_create(struct xe_hw_fence_ctx *ctx, 
	if (!fence)

		return ERR_PTR(-ENOMEM);



	dma_fence_init(&fence->dma, &xe_hw_fence_ops, &ctx->irq->lock,

		       ctx->dma_fence_ctx, ctx->next_seqno++);



	fence->ctx = ctx;

	fence->seqno_map = seqno_map;

	INIT_LIST_HEAD(&fence->irq_link);



	dma_fence_init(&fence->dma, &xe_hw_fence_ops, &ctx->irq->lock,

		       ctx->dma_fence_ctx, ctx->next_seqno++);



	trace_xe_hw_fence_create(fence);



	return fence;