Commit c69e1396 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Jonathan Cameron
Browse files

iio: adc: rzg2l_adc: Set driver data before enabling runtime PM 



When stress-testing the system by repeatedly unbinding and binding the ADC
device in a loop, and the ADC is a supplier for another device (e.g., a
thermal hardware block that reads temperature through the ADC), it may
happen that the ADC device is runtime-resumed immediately after runtime PM
is enabled, triggered by its consumer. At this point, since drvdata is not
yet set and the driver's runtime PM callbacks rely on it, a crash can
occur. To avoid this, set drvdata just after it was allocated.

Fixes: 89ee8174 ("iio: adc: rzg2l_adc: Simplify the runtime PM code")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20250810123328.800104-3-claudiu.beznea.uj@bp.renesas.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a3c6eabe

drivers/iio/adc/rzg2l_adc.c

+2 −2
Original line number Diff line number Diff line
@@ -427,6 +427,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev) 
	if (!indio_dev)

		return -ENOMEM;



	platform_set_drvdata(pdev, indio_dev);



	adc = iio_priv(indio_dev);



	adc->hw_params = device_get_match_data(dev);
@@ -459,8 +461,6 @@ static int rzg2l_adc_probe(struct platform_device *pdev) 
	if (ret)

		return ret;



	platform_set_drvdata(pdev, indio_dev);



	ret = rzg2l_adc_hw_init(dev, adc);

	if (ret)

		return dev_err_probe(&pdev->dev, ret,