Commit c6bb8a21 authored by Wentao Liang's avatar Wentao Liang Committed by Jakub Kicinski
Browse files

net/mlx5: Add error handling in mlx5_query_nic_vport_node_guid() 



The function mlx5_query_nic_vport_node_guid() calls the function
mlx5_query_nic_vport_context() but does not check its return value.
A proper implementation can be found in mlx5_nic_vport_query_local_lb().

Add error handling for mlx5_query_nic_vport_context(). If it fails, free
the out buffer via kvfree() and return error code.

Fixes: 9efa7525 ("net/mlx5_core: Introduce access functions to query vport RoCE fields")
Cc: stable@vger.kernel.org # v4.5
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250524163425.1695-1-vulab@iscas.ac.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c5978378

drivers/net/ethernet/mellanox/mlx5/core/vport.c

+6 −3
Original line number Diff line number Diff line
@@ -465,19 +465,22 @@ int mlx5_query_nic_vport_node_guid(struct mlx5_core_dev *mdev, u64 *node_guid) 
{

	u32 *out;

	int outlen = MLX5_ST_SZ_BYTES(query_nic_vport_context_out);

	int err;



	out = kvzalloc(outlen, GFP_KERNEL);

	if (!out)

		return -ENOMEM;



	mlx5_query_nic_vport_context(mdev, 0, out);

	err = mlx5_query_nic_vport_context(mdev, 0, out);

	if (err)

		goto out;



	*node_guid = MLX5_GET64(query_nic_vport_context_out, out,

				nic_vport_context.node_guid);



out:

	kvfree(out);



	return 0;

	return err;

}

EXPORT_SYMBOL_GPL(mlx5_query_nic_vport_node_guid);