Commit c6ccb691 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Ulf Hansson
Browse files

pmdomain: core: Reduce debug summary table width 



Commit 9094e53f ("pmdomain: core: Use dev_name() instead of
kobject_get_path() in debugfs") severely shortened the names of devices
in a PM Domain.  Now the most common format[1] consists of a 32-bit
unit-address (8 characters), followed by a dot and a node name (20
characters for "air-pollution-sensor" and "interrupt-controller", which
are the longest generic node names documented in the Devicetree
Specification), for a typical maximum of 29 characters.

This offers a good opportunity to reduce the table width of the debug
summary:
  - Reduce the device name field width from 50 to 30 characters, which
    matches the PM Domain name width,
  - Reduce the large inter-column space between the "performance" and
    "managed by" columns.

Visual impact:
  - The "performance" column now starts at a position that is a
    multiple of 16, just like the "status" and "children" columns,
  - All of the "/device", "runtime status", and "managed by" columns are
    now indented 4 characters more than the columns right above them,
  - Everything fits in (one less than) 80 characters again ;-)

[1] Note that some device names (e.g. TI AM335x interconnect target
    modules) do not follow this convention, and may be much longer, but
    these didn't fit in the old 50-character column width either.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/f8e1821364b6d5d11350447c128f6d2b470f33fe.1725459707.git.geert+renesas@glider.be


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 2fc93419

drivers/pmdomain/core.c

+7 −7
Original line number Diff line number Diff line
@@ -3227,7 +3227,7 @@ static void rtpm_status_str(struct seq_file *s, struct device *dev) 
	else

		WARN_ON(1);



	seq_printf(s, "%-25s  ", p);

	seq_printf(s, "%-26s  ", p);

}



static void perf_status_str(struct seq_file *s, struct device *dev)
@@ -3245,7 +3245,7 @@ static void mode_status_str(struct seq_file *s, struct device *dev) 


	gpd_data = to_gpd_data(dev->power.subsys_data->domain_data);



	seq_printf(s, "%9s", gpd_data->hw_mode ? "HW" : "SW");

	seq_printf(s, "%2s", gpd_data->hw_mode ? "HW" : "SW");

}



static int genpd_summary_one(struct seq_file *s,
@@ -3272,7 +3272,7 @@ static int genpd_summary_one(struct seq_file *s, 
	else

		snprintf(state, sizeof(state), "%s",

			 status_lookup[genpd->status]);

	seq_printf(s, "%-30s  %-49s  %u", genpd->name, state, genpd->performance_state);

	seq_printf(s, "%-30s  %-30s  %u", genpd->name, state, genpd->performance_state);



	/*

	 * Modifications on the list require holding locks on both
@@ -3288,7 +3288,7 @@ static int genpd_summary_one(struct seq_file *s, 
	}



	list_for_each_entry(pm_data, &genpd->dev_list, list_node) {

		seq_printf(s, "\n    %-50s  ", dev_name(pm_data->dev));

		seq_printf(s, "\n    %-30s  ", dev_name(pm_data->dev));

		rtpm_status_str(s, pm_data->dev);

		perf_status_str(s, pm_data->dev);

		mode_status_str(s, pm_data->dev);
@@ -3308,7 +3308,7 @@ static int summary_show(struct seq_file *s, void *data) 


	seq_puts(s, "domain                          status          children        performance\n");

	seq_puts(s, "    /device                         runtime status                  managed by\n");

	seq_puts(s, "------------------------------------------------------------------------------------------------------------\n");

	seq_puts(s, "------------------------------------------------------------------------------\n");



	ret = mutex_lock_interruptible(&gpd_list_lock);

	if (ret)