Commit c7046ed0 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Improve stripe checksum error message 



We now include the name of the device in the error message - and also
increment the number of checksum errors on that device.

Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 853960d0

fs/bcachefs/ec.c

+13 −8
Original line number Diff line number Diff line
@@ -304,16 +304,21 @@ static void ec_validate_checksums(struct bch_fs *c, struct ec_stripe_buf *buf) 
			struct bch_csum got = ec_block_checksum(buf, i, offset);



			if (bch2_crc_cmp(want, got)) {

				struct printbuf buf2 = PRINTBUF;

				struct printbuf err = PRINTBUF;

				struct bch_dev *ca = bch_dev_bkey_exists(c, v->ptrs[i].dev);



				prt_printf(&err, "stripe checksum error: expected %0llx:%0llx got %0llx:%0llx (type %s)\n",

					   want.hi, want.lo,

					   got.hi, got.lo,

					   bch2_csum_types[v->csum_type]);

				prt_printf(&err, "  for %ps at %u of\n  ", (void *) _RET_IP_, i);

				bch2_bkey_val_to_text(&err, c, bkey_i_to_s_c(&buf->key));

				bch_err_ratelimited(ca, "%s", err.buf);

				printbuf_exit(&err);



				bch2_bkey_val_to_text(&buf2, c, bkey_i_to_s_c(&buf->key));



				bch_err_ratelimited(c,

					"stripe checksum error for %ps at %u:%u: csum type %u, expected %llx got %llx\n%s",

					(void *) _RET_IP_, i, j, v->csum_type,

					want.lo, got.lo, buf2.buf);

				printbuf_exit(&buf2);

				clear_bit(i, buf->valid);



				bch2_io_error(ca, BCH_MEMBER_ERROR_checksum);

				break;

			}