Commit c719fd3e authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: xlp: drop unneeded ngpio checks 

GPIO core already makes sure that offsets higher than the number of GPIOs
are never passed to controller callbacks. We can remove the unnecessary
check.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-11-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 1919ea19

drivers/gpio/gpio-xlp.c

+0 −4
Original line number Diff line number Diff line
@@ -206,7 +206,6 @@ static int xlp_gpio_dir_output(struct gpio_chip *gc, unsigned gpio, int state) 
{

	struct xlp_gpio_priv *priv = gpiochip_get_data(gc);



	BUG_ON(gpio >= gc->ngpio);

	xlp_gpio_set_reg(priv->gpio_out_en, gpio, 0x1);



	return 0;
@@ -216,7 +215,6 @@ static int xlp_gpio_dir_input(struct gpio_chip *gc, unsigned gpio) 
{

	struct xlp_gpio_priv *priv = gpiochip_get_data(gc);



	BUG_ON(gpio >= gc->ngpio);

	xlp_gpio_set_reg(priv->gpio_out_en, gpio, 0x0);



	return 0;
@@ -226,7 +224,6 @@ static int xlp_gpio_get(struct gpio_chip *gc, unsigned gpio) 
{

	struct xlp_gpio_priv *priv = gpiochip_get_data(gc);



	BUG_ON(gpio >= gc->ngpio);

	return xlp_gpio_get_reg(priv->gpio_paddrv, gpio);

}
@@ -234,7 +231,6 @@ static void xlp_gpio_set(struct gpio_chip *gc, unsigned gpio, int state) 
{

	struct xlp_gpio_priv *priv = gpiochip_get_data(gc);



	BUG_ON(gpio >= gc->ngpio);

	xlp_gpio_set_reg(priv->gpio_paddrv, gpio, state);

}