Commit c72e61b5 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: aspeed: use new line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-13-1d5cceeebf8b@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 4cdc1912

drivers/gpio/gpio-aspeed.c

+4 −3
Original line number Diff line number Diff line
@@ -424,8 +424,7 @@ static void __aspeed_gpio_set(struct gpio_chip *gc, unsigned int offset, 
	gpio->config->llops->reg_bit_get(gpio, offset, reg_val);

}



static void aspeed_gpio_set(struct gpio_chip *gc, unsigned int offset,

			    int val)

static int aspeed_gpio_set(struct gpio_chip *gc, unsigned int offset, int val)

{

	struct aspeed_gpio *gpio = gpiochip_get_data(gc);

	bool copro = false;
@@ -438,6 +437,8 @@ static void aspeed_gpio_set(struct gpio_chip *gc, unsigned int offset, 


	if (copro)

		aspeed_gpio_copro_release(gpio, offset);



	return 0;

}



static int aspeed_gpio_dir_in(struct gpio_chip *gc, unsigned int offset)
@@ -1351,7 +1352,7 @@ static int aspeed_gpio_probe(struct platform_device *pdev) 
	gpio->chip.request = aspeed_gpio_request;

	gpio->chip.free = aspeed_gpio_free;

	gpio->chip.get = aspeed_gpio_get;

	gpio->chip.set = aspeed_gpio_set;

	gpio->chip.set_rv = aspeed_gpio_set;

	gpio->chip.set_config = aspeed_gpio_set_config;

	gpio->chip.label = dev_name(&pdev->dev);

	gpio->chip.base = -1;