Unverified Commit c73be62c authored by Frieder Schrempf's avatar Frieder Schrempf Committed by Mark Brown
Browse files

Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5" 



This reverts commit 8c67a11b.

It turns out that all boards using the PCA9450 actually have the
SD_VSEL input connected to the VSELECT signal of the SoCs SD/MMC
interface or use a fixed level.

The assumptions on which this was implemented were wrong. There
is no need for a GPIO-only-based approach and keeping this will
cause confusion and lead people to implement non-standard setups.

All in-tree users of this have been migrated and we can savely
remove this now and allow for a more future-proof approach
of syncing the actual status of SD_VSEL and the PMIC driver.

Signed-off-by: default avatarFrieder Schrempf <frieder.schrempf@kontron.de>
Link: https://patch.msgid.link/20241218152842.97483-4-frieder@fris.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent b5ec74c2

drivers/regulator/pca9450-regulator.c

+0 −13
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ 
 */



#include <linux/err.h>

#include <linux/gpio/consumer.h>

#include <linux/i2c.h>

#include <linux/interrupt.h>

#include <linux/kernel.h>
@@ -32,7 +31,6 @@ struct pca9450_regulator_desc { 
struct pca9450 {

	struct device *dev;

	struct regmap *regmap;

	struct gpio_desc *sd_vsel_gpio;

	enum pca9450_chip_type type;

	unsigned int rcnt;

	int irq;
@@ -1031,17 +1029,6 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) 
					     "Failed to enable I2C level translator\n");

	}



	/*

	 * The driver uses the LDO5CTRL_H register to control the LDO5 regulator.

	 * This is only valid if the SD_VSEL input of the PMIC is high. Let's

	 * check if the pin is available as GPIO and set it to high.

	 */

	pca9450->sd_vsel_gpio = gpiod_get_optional(pca9450->dev, "sd-vsel", GPIOD_OUT_HIGH);



	if (IS_ERR(pca9450->sd_vsel_gpio))

		return dev_err_probe(&i2c->dev, PTR_ERR(pca9450->sd_vsel_gpio),

				     "Failed to get SD_VSEL GPIO\n");



	dev_info(&i2c->dev, "%s probed.\n",

		type == PCA9450_TYPE_PCA9450A ? "pca9450a" :

		(type == PCA9450_TYPE_PCA9451A ? "pca9451a" : "pca9450bc"));