Commit c73d583e authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

xfrm: snmp: do not use SNMP_MIB_SENTINEL anymore 



Use ARRAY_SIZE(), so that we know the limit at compile time.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Reviewed-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/20250905165813.1470708-9-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3a951f95

net/xfrm/xfrm_proc.c

+6 −6
Original line number Diff line number Diff line
@@ -45,21 +45,21 @@ static const struct snmp_mib xfrm_mib_list[] = { 
	SNMP_MIB_ITEM("XfrmInStateDirError", LINUX_MIB_XFRMINSTATEDIRERROR),

	SNMP_MIB_ITEM("XfrmInIptfsError", LINUX_MIB_XFRMINIPTFSERROR),

	SNMP_MIB_ITEM("XfrmOutNoQueueSpace", LINUX_MIB_XFRMOUTNOQSPACE),

	SNMP_MIB_SENTINEL

};



static int xfrm_statistics_seq_show(struct seq_file *seq, void *v)

{

	unsigned long buff[LINUX_MIB_XFRMMAX];

	unsigned long buff[ARRAY_SIZE(xfrm_mib_list)];

	const int cnt = ARRAY_SIZE(xfrm_mib_list);

	struct net *net = seq->private;

	int i;



	memset(buff, 0, sizeof(unsigned long) * LINUX_MIB_XFRMMAX);

	memset(buff, 0, sizeof(buff));



	xfrm_state_update_stats(net);

	snmp_get_cpu_field_batch(buff, xfrm_mib_list,

	snmp_get_cpu_field_batch_cnt(buff, xfrm_mib_list, cnt,

				     net->mib.xfrm_statistics);

	for (i = 0; xfrm_mib_list[i].name; i++)

	for (i = 0; i < cnt; i++)

		seq_printf(seq, "%-24s\t%lu\n", xfrm_mib_list[i].name,

						buff[i]);