Commit c7568e78 authored by Lukasz Luba's avatar Lukasz Luba Committed by Rafael J. Wysocki
Browse files

thermal: gov_power_allocator: Check the cooling devices only for trip_max 



The throttling logic only cares about the last passive trip point and
the cooling devices attached to it.

Therefore, there is no need to bail out if other trip points have
cooling devices which are not a supported by the IPA.

Check the cooling devices only for 'trip_max' during the binding.

Signed-off-by: default avatarLukasz Luba <lukasz.luba@arm.com>
[ rjw: Changelog edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent e83747c2

drivers/thermal/gov_power_allocator.c

+7 −2
Original line number Diff line number Diff line
@@ -578,6 +578,7 @@ static void allow_maximum_power(struct thermal_zone_device *tz, bool update) 
 * check_power_actors() - Check all cooling devices and warn when they are

 *			not power actors

 * @tz:		thermal zone to operate on

 * @params:	power allocator private data

 *

 * Check all cooling devices in the @tz and warn every time they are missing

 * power actor API. The warning should help to investigate the issue, which
@@ -586,12 +587,16 @@ static void allow_maximum_power(struct thermal_zone_device *tz, bool update) 
 * Return: 0 on success, -EINVAL if any cooling device does not implement

 * the power actor API.

 */

static int check_power_actors(struct thermal_zone_device *tz)

static int check_power_actors(struct thermal_zone_device *tz,

			      struct power_allocator_params *params)

{

	struct thermal_instance *instance;

	int ret = 0;



	list_for_each_entry(instance, &tz->thermal_instances, tz_node) {

		if (instance->trip != params->trip_max)

			continue;



		if (!cdev_is_power_actor(instance->cdev)) {

			dev_warn(&tz->device, "power_allocator: %s is not a power actor\n",

				 instance->cdev->type);
@@ -628,7 +633,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz) 
		return -EINVAL;

	}



	ret = check_power_actors(tz);

	ret = check_power_actors(tz, params);

	if (ret) {

		dev_warn(&tz->device, "power_allocator: binding failed\n");

		kfree(params);