Commit c75fb88d authored by Pavel Roskin's avatar Pavel Roskin Committed by Linus Torvalds
Browse files

[PATCH] Fix sparse annotation of spin unlock macros in one case 



SMP systems without premption and spinlock debugging enabled use unlock
macros that don't tell sparse that the lock is being released.  Add sparse
annotations in this case.

Signed-off-by: default avatarPavel Roskin <proski@gnu.org>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent aa0f0303

include/linux/spinlock.h

+24 −9
Original line number Diff line number Diff line
@@ -228,15 +228,30 @@ do { \ 
# define read_unlock_irq(lock)		_read_unlock_irq(lock)

# define write_unlock_irq(lock)		_write_unlock_irq(lock)

#else

# define spin_unlock(lock)		__raw_spin_unlock(&(lock)->raw_lock)

# define read_unlock(lock)		__raw_read_unlock(&(lock)->raw_lock)

# define write_unlock(lock)		__raw_write_unlock(&(lock)->raw_lock)

# define spin_unlock(lock) \

    do {__raw_spin_unlock(&(lock)->raw_lock); __release(lock); } while (0)

# define read_unlock(lock) \

    do {__raw_read_unlock(&(lock)->raw_lock); __release(lock); } while (0)

# define write_unlock(lock) \

    do {__raw_write_unlock(&(lock)->raw_lock); __release(lock); } while (0)

# define spin_unlock_irq(lock)			\

    do { __raw_spin_unlock(&(lock)->raw_lock); local_irq_enable(); } while (0)

do {						\

	__raw_spin_unlock(&(lock)->raw_lock);	\

	__release(lock);			\

	local_irq_enable();			\

} while (0)

# define read_unlock_irq(lock)			\

    do { __raw_read_unlock(&(lock)->raw_lock); local_irq_enable(); } while (0)

do {						\

	__raw_read_unlock(&(lock)->raw_lock);	\

	__release(lock);			\

	local_irq_enable();			\

} while (0)

# define write_unlock_irq(lock)			\

    do { __raw_write_unlock(&(lock)->raw_lock); local_irq_enable(); } while (0)

do {						\

	__raw_write_unlock(&(lock)->raw_lock);	\

	__release(lock);			\

	local_irq_enable();			\

} while (0)

#endif



#define spin_unlock_irqrestore(lock, flags) \