Commit c7719496 authored by Max Kellermann's avatar Max Kellermann Committed by Theodore Ts'o
Browse files

Revert "ext4: apply umask if ACL support is disabled" 

This reverts commit 484fd6c1.  The
commit caused a regression because now the umask was applied to
symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
has been fixed somewhere else already.

Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/


Signed-off-by: default avatarMax Kellermann <max.kellermann@ionos.com>
Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Tested-by: default avatarMichael Forney <mforney@mforney.org>
Link: https://lore.kernel.org/r/20240315142956.2420360-1-max.kellermann@ionos.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent fb092d40

fs/ext4/acl.h

+0 −5
Original line number Diff line number Diff line
@@ -68,11 +68,6 @@ extern int ext4_init_acl(handle_t *, struct inode *, struct inode *); 
static inline int

ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)

{

	/* usually, the umask is applied by posix_acl_create(), but if

	   ext4 ACL support is disabled at compile time, we need to do

	   it here, because posix_acl_create() will never be called */

	inode->i_mode &= ~current_umask();



	return 0;

}

#endif  /* CONFIG_EXT4_FS_POSIX_ACL */