Commit c79a7ca8 authored by Salah Triki's avatar Salah Triki Committed by Manivannan Sadhasivam
Browse files

PCI: mvebu: Use devm_add_action_or_reset() instead of devm_add_action() 



Replace devm_add_action() with devm_add_action_or_reset() to avoid
explicitly dropping the 'port->clk' reference in error path.

Signed-off-by: default avatarSalah Triki <salah.triki@gmail.com>
[mani: reworded commit subject and description]
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/aHsgYALHfQbrgq0t@pc
parent 19272b37

drivers/pci/controller/pci-mvebu.c

+2 −4
Original line number Diff line number Diff line
@@ -1353,11 +1353,9 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie, 
		goto skip;

	}



	ret = devm_add_action(dev, mvebu_pcie_port_clk_put, port);

	if (ret < 0) {

		clk_put(port->clk);

	ret = devm_add_action_or_reset(dev, mvebu_pcie_port_clk_put, port);

	if (ret < 0)

		goto err;

	}



	return 1;