Unverified Commit c7b49506 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Rodrigo Vivi
Browse files

drm/i915: Drop 64bpp YUV formats from ICL+ SDR planes 



I'm seeing underruns with these 64bpp YUV formats on TGL.

The weird details:
- only happens on pipe B/C/D SDR planes, pipe A SDR planes
  seem fine, as do all HDR planes
- somehow CDCLK related, higher CDCLK allows for bigger plane
  with these formats without underruns. With 300MHz CDCLK I
  can only go up to 1200 pixels wide or so, with 650MHz even
  a 3840 pixel wide plane was OK
- ICL and ADL so far appear unaffected

So not really sure what's the deal with this, but bspec does
state "64-bit formats supported only on the HDR planes" so
let's just drop these formats from the SDR planes. We already
disallow 64bpp RGB formats.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241218173650.19782-2-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJuha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
(cherry picked from commit 35e1aacf)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent fa6182c8

drivers/gpu/drm/i915/display/skl_universal_plane.c

+0 −4
Original line number Diff line number Diff line
@@ -106,8 +106,6 @@ static const u32 icl_sdr_y_plane_formats[] = { 
	DRM_FORMAT_Y216,

	DRM_FORMAT_XYUV8888,

	DRM_FORMAT_XVYU2101010,

	DRM_FORMAT_XVYU12_16161616,

	DRM_FORMAT_XVYU16161616,

};



static const u32 icl_sdr_uv_plane_formats[] = {
@@ -134,8 +132,6 @@ static const u32 icl_sdr_uv_plane_formats[] = { 
	DRM_FORMAT_Y216,

	DRM_FORMAT_XYUV8888,

	DRM_FORMAT_XVYU2101010,

	DRM_FORMAT_XVYU12_16161616,

	DRM_FORMAT_XVYU16161616,

};



static const u32 icl_hdr_plane_formats[] = {