Unverified Commit c7f06284 authored by Dan Carpenter's avatar Dan Carpenter Committed by Arnd Bergmann
Browse files

ep93xx: clock: Fix off by one in ep93xx_div_recalc_rate() 



The psc->div[] array has psc->num_div elements.  These values come from
when we call clk_hw_register_div().  It's adc_divisors and
ARRAY_SIZE(adc_divisors)) and so on.  So this condition needs to be >=
instead of > to prevent an out of bounds read.

Fixes: 9645ccc7 ("ep93xx: clock: convert in-place to COMMON_CLK")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarAlexander Sverdlin <alexander.sverdlin@gmail.com>
Reviewed-by: default avatarNikita Shubin <nikita.shubin@maquefel.me>
Signed-off-by: default avatarAlexander Sverdlin <alexander.sverdlin@gmail.com>
Link: https://lore.kernel.org/r/1caf01ad4c0a8069535813c26c7f0b8ea011155e.camel@linaro.org


Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 47ac09b9

arch/arm/mach-ep93xx/clock.c

+1 −1
Original line number Diff line number Diff line
@@ -359,7 +359,7 @@ static unsigned long ep93xx_div_recalc_rate(struct clk_hw *hw, 
	u32 val = __raw_readl(psc->reg);

	u8 index = (val & psc->mask) >> psc->shift;



	if (index > psc->num_div)

	if (index >= psc->num_div)

		return 0;



	return DIV_ROUND_UP_ULL(parent_rate, psc->div[index]);