Commit c7f6d538 authored by Peter Colberg's avatar Peter Colberg Committed by Danilo Krummrich
Browse files

rust: pci: refer to legacy as INTx interrupts 

Consistently use INTx, as in the description of IrqType::Intx, to refer
to the four legacy PCI interrupts, INTA#, INTB#, INTC#, and INTD#.

Link: https://lore.kernel.org/rust-for-linux/20251015230209.GA960343@bhelgaas/
Link: https://github.com/Rust-for-Linux/linux/issues/1196


Suggested-by: default avatarBjorn Helgaas <helgaas@kernel.org>
Signed-off-by: default avatarPeter Colberg <pcolberg@redhat.com>
Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 6d0ef689

rust/kernel/pci/irq.rs

+5 −5
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ const fn as_raw(self) -> u32 { 
pub struct IrqTypes(u32);



impl IrqTypes {

    /// Create a set containing all IRQ types (MSI-X, MSI, and Legacy).

    /// Create a set containing all IRQ types (MSI-X, MSI, and INTx).

    pub const fn all() -> Self {

        Self(bindings::PCI_IRQ_ALL_TYPES)

    }
@@ -52,7 +52,7 @@ pub const fn all() -> Self { 
    /// # Examples

    ///

    /// ```ignore

    /// // Create a set with only MSI and MSI-X (no legacy interrupts).

    /// // Create a set with only MSI and MSI-X (no INTx interrupts).

    /// let msi_only = IrqTypes::default()

    ///     .with(IrqType::Msi)

    ///     .with(IrqType::MsiX);
@@ -199,9 +199,9 @@ pub fn request_threaded_irq<'a, T: crate::irq::ThreadedHandler + 'static>( 
    /// Allocate IRQ vectors for this PCI device with automatic cleanup.

    ///

    /// Allocates between `min_vecs` and `max_vecs` interrupt vectors for the device.

    /// The allocation will use MSI-X, MSI, or legacy interrupts based on the `irq_types`

    /// The allocation will use MSI-X, MSI, or INTx interrupts based on the `irq_types`

    /// parameter and hardware capabilities. When multiple types are specified, the kernel

    /// will try them in order of preference: MSI-X first, then MSI, then legacy interrupts.

    /// will try them in order of preference: MSI-X first, then MSI, then INTx interrupts.

    ///

    /// The allocated vectors are automatically freed when the device is unbound, using the

    /// devres (device resource management) system.
@@ -225,7 +225,7 @@ pub fn request_threaded_irq<'a, T: crate::irq::ThreadedHandler + 'static>( 
    /// // Allocate using any available interrupt type in the order mentioned above.

    /// let vectors = dev.alloc_irq_vectors(1, 32, pci::IrqTypes::all())?;

    ///

    /// // Allocate MSI or MSI-X only (no legacy interrupts).

    /// // Allocate MSI or MSI-X only (no INTx interrupts).

    /// let msi_only = pci::IrqTypes::default()

    ///     .with(pci::IrqType::Msi)

    ///     .with(pci::IrqType::MsiX);