Commit c8098ad8 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Bjorn Helgaas
Browse files

PCI: Remove incorrect comment from pci_reassign_resource() 

Commit a4ac9fea ("PCI : Calculate right add_size") removed including
min_align into new_size in pci_reassign_resource() which is the correct
thing to do. However, it also added a snakeoil comment that the resource
would already be aligned with min_align which is incorrect.

A resource that is assigned earlier is aligned with the old alignment, NOT
with the new requested alignment (min_align) until later deep within the
reassignment callchain. Thus, remove the incorrect comment.

Link: https://lore.kernel.org/r/20241216175632.4175-18-ilpo.jarvinen@linux.intel.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Tested-by: default avatarXiaochun Lee <lixc17@lenovo.com>
Cc: Yinghai Lu <yinghai@kernel.org>
parent ca9097f9

drivers/pci/setup-res.c

+0 −1
Original line number Diff line number Diff line
@@ -387,7 +387,6 @@ int pci_reassign_resource(struct pci_dev *dev, int resno, 
		return -EINVAL;

	}



	/* already aligned with min_align */

	new_size = resource_size(res) + addsize;

	ret = _pci_assign_resource(dev, resno, new_size, min_align);

	if (ret) {